Fix: Use existing reference if name resolver returns None#359
Merged
Conversation
Member
Author
Bangertm
approved these changes
Jan 25, 2019
Collaborator
Bangertm
left a comment
Bangertm
left a comment
There was a problem hiding this comment.
Yes this looks good. I hadn't considered this case.
Member
Author
|
Yeah, that's really a corner case. Anyway, it's more logical this way. No need to generate a name if the schema is already registered. Let's merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverses the logic in
resolve_nested_schemato give priority to existing reference.