Conversation
sloria
left a comment
sloria
left a comment
There was a problem hiding this comment.
Just a little nit. Go ahead and address and merge, or we can address it later.
I wouldn't consider this a breaking change because it's not an API change. This warrants a minor version bump.
| plugins=(MarshmallowPlugin(schema_name_resolver=resolver),), | ||
| ) | ||
| assert {} == get_schemas(spec) | ||
| assert get_schemas(spec) is None |
There was a problem hiding this comment.
Nit: It might be good for the get_ functions to default to a sentinel value, like marshmallow.missing.
There was a problem hiding this comment.
I'd rather avoid missing as this could pass a wrong change leaking the missing object into the generated spec.
I could create a dedicated MISSING_FROM_SPEC singleton.
Overall, it looks just as simple to catch KeyError. Also, when using OAS3, KeyError covers the case where the whole components section is missing. See new commit.
|
Is there a corresponding issue for this PR? I thought I remember seeing one but I can't find it. |
|
Just a comment: #408 (comment). |
|
Merged. Thanks for reviewing. |
|
No prob. Will you take care of the release, or shall I do that? |
|
I can. Never did. Do I just need to push a tag? |
|
Yeah, pretty much. The process is the same as marshmallow's: https://github.com/marshmallow-code/marshmallow/blob/dev/RELEASING.md |
|
Thanks. I never noticed this file. |
|
Done. I added release notes on Tidelift for 1.1.0 and 1.1.1. 1.1.2 and 1.2.0 are not there yet. |
2 participants
This PR removes empty component subsections (parameters, responses, etc.) from the docs.
I'm tempted not to consider that a breaking change.