Fix circular references#44
Conversation
There was a problem hiding this comment.
If you pass *args and **kwargs to the super call, can this update call be removed?
There was a problem hiding this comment.
yes I guess it was a remnant of another experiment, I guess I can remove the __init__ entirely
|
Thanks for the PR! Just a few driveby comments for now. I will try to look at this more closely over the holidays |
|
no problem! I don't know how bulletproof that lazy dictionary is, but it gets the job done. Another change that would involve breaking the apis would be to first declaring the schema through |
|
Any chance you looked at this? I can look at the conflicts if you think the general idea is sound |
|
@itajaja Apologies for the delay. The approach is sound; works as advertised. Just a few nitpicks
|
using a lazy loading dictionary, it's possible to delay the schema definition, so that the references schema references are solved after the schemas are registered with the function
8e39c78 to
fa1ec52
Compare
|
added your nits, resolved conflicts and squashed 🍷 |
|
Thanks! |
fixes #41