Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework name resolver #476

Merged
merged 3 commits into from Aug 21, 2019

Conversation

@Bangertm
Copy link
Collaborator

commented Jul 19, 2019

Changes the schema_name_resolver function to be able to accept either a Schema class, Schema instance or a string that resolves to a Schema class.

resolves #475

@lafrech lafrech self-requested a review Jul 19, 2019

@lafrech
Copy link
Member

left a comment

LGTM. Thanks.

@lafrech

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

I think this is gonna be a 3.0.0 since it changes what the resolver can receive.

Bangertm added 3 commits Jul 19, 2019
remove unused method
Custom resolution of a schema class can now be done directly in a
custom schema_name_resolver function

@Bangertm Bangertm force-pushed the rework-name-resolver branch from a594ef7 to d880079 Jul 31, 2019

@lafrech

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Sorry @Bangertm for the delay. I just reviewed this again and I think it is good to go.

Thanks.

@lafrech lafrech merged commit 78b1480 into dev Aug 21, 2019

11 checks passed

marshmallow-code.apispec Build #20190731.5 succeeded
Details
marshmallow-code.apispec (tox_linux docs) tox_linux docs succeeded
Details
marshmallow-code.apispec (tox_linux lint) tox_linux lint succeeded
Details
marshmallow-code.apispec (tox_linux py27-marshmallow2) tox_linux py27-marshmallow2 succeeded
Details
marshmallow-code.apispec (tox_linux py35-marshmallow2) tox_linux py35-marshmallow2 succeeded
Details
marshmallow-code.apispec (tox_linux py35-marshmallow3) tox_linux py35-marshmallow3 succeeded
Details
marshmallow-code.apispec (tox_linux py36-marshmallow2) tox_linux py36-marshmallow2 succeeded
Details
marshmallow-code.apispec (tox_linux py36-marshmallow3) tox_linux py36-marshmallow3 succeeded
Details
marshmallow-code.apispec (tox_linux py37-marshmallow2) tox_linux py37-marshmallow2 succeeded
Details
marshmallow-code.apispec (tox_linux py37-marshmallow3) tox_linux py37-marshmallow3 succeeded
Details
marshmallow-code.apispec (tox_linux py37-marshmallowdev) tox_linux py37-marshmallowdev succeeded
Details
@lafrech

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

This will be a 3.0.0.

If we don't manage to review #478 quickly to cram it into the release, I'll release 3.0.0 without it and it will be 3.1.0 (or 4.0.0 if it is not backwards compatible).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.