Conversation
Member
|
I think this is gonna be a 3.0.0 since it changes what the resolver can receive. |
Custom resolution of a schema class can now be done directly in a custom schema_name_resolver function
Bangertm
force-pushed
the
rework-name-resolver
branch
from
a594ef7 to
d880079
Compare
Member
|
Sorry @Bangertm for the delay. I just reviewed this again and I think it is good to go. Thanks. |
Member
|
This will be a 3.0.0. If we don't manage to review #478 quickly to cram it into the release, I'll release 3.0.0 without it and it will be 3.1.0 (or 4.0.0 if it is not backwards compatible). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the
schema_name_resolverfunction to be able to accept either aSchemaclass,Schemainstance or a string that resolves to aSchemaclass.resolves #475