Conversation
sloria
approved these changes
Aug 18, 2020
Member
There was a problem hiding this comment.
Can also replace --py3-plus with --py36-plus in pyupgrade:
apispec/.pre-commit-config.yaml
Line 6 in f075149
We should also probably use pyproject.toml with a black config that has
[tool.black]
line-length = 79
target-version = ['py36', 'py37', 'py38']
lafrech
force-pushed
the
drop_py35
branch
2 times, most recently
from
b23caff to
cd091d7
Compare
Member
Author
|
Changed to py36-plus. About the pyproject file, whatever you say, I've never looked into black configuration so I'm trusting you. I think we use a longer line length, though. Did you mean 99? |
Member
|
Woops, yeah I typod. We should probably match marshmallow's config [tool.black]
line-length = 88
target-version = ['py35', 'py36', 'py37', 'py38'] |
lafrech
force-pushed
the
drop_py35
branch
2 times, most recently
from
d3d3995 to
de387b7
Compare
sloria
approved these changes
Aug 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #556.