Merged
Conversation
lafrech
force-pushed
the
fix_metadata_keyword_warning
branch
from
1f64e65 to
f015664
Compare
Member
Author
|
The only changes are in the tests, not in the source code (except for docstring examples). This requires to bump marshmallow version to 3.10 for the tests but it is not a breaking change for the code itself. apispec still works with marshmallow >=3,< 3.10. I don't think it is worth complicating things to try to also test on marshmallow 3.0. We can always drop marshmallow < 3.10 in next major and until then only test on 3.10+ and know it works on marshmallow 3.0. |
lafrech
force-pushed
the
fix_metadata_keyword_warning
branch
from
f015664 to
6d60a6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is deprecated and generates warnings.