Skip to content

Add writeOnly and nullable to _VALID_PROPERTIES list#684

Merged
lafrech merged 1 commit intomarshmallow-code:devfrom
greyli:ma-metadata
Jun 28, 2021
Merged

Add writeOnly and nullable to _VALID_PROPERTIES list#684
lafrech merged 1 commit intomarshmallow-code:devfrom
greyli:ma-metadata

Conversation

@greyli
Copy link
Copy Markdown
Contributor

@greyli greyli commented Jun 25, 2021

The nullable and writeOnly are supported but not in the _VALID_PROPERTIES list. This PR also adds tests for readOnly and writeOnly.

P.S. I also found the metadata accepts "doc_default", is it a deprecated value (since we already have default)?

@lafrech lafrech merged commit 1096289 into marshmallow-code:dev Jun 28, 2021
@lafrech
Copy link
Copy Markdown
Member

lafrech commented Jun 28, 2021

Thanks.

Regarding doc_default, see #196. But thanks for the heads up because since metadata is namespaced in marshmallow, the doc_default thing shouldn't be necessary. We shall remove it in apispec 5 (#687).

@greyli greyli deleted the ma-metadata branch June 28, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants