Add type hints#747
Conversation
|
@lafrech I added as many type hints as possible. Can you please have a look? |
lafrech
left a comment
There was a problem hiding this comment.
Thank you very much already for the contribution.
I didn't review thoroughly already, but this looks good.
I think we should use
from __future__ import annotations
good idea. I changed the hints to that system |
|
I got this weird CI error: |
|
Strange. We're about to migrate from Azure, anyway. To GH actions + pre-commit.ci. Please give me a little time to check this. Thanks again. |
lafrech
left a comment
There was a problem hiding this comment.
Looks pretty good.
Do you think you could squash all your commits and push-force?
This would provide a nicer commit history and it would also trigger a new CI run. Not sure what failed with Azure, let's see how it goes this time.
Thanks.
|
@lafrech the CI still doesn't work. I tried to squash everything but merge commits and rebases are not nice. |
|
Indeed, I read a bit more about the CI error message. I don't want to struggle with this while about to change CI anyway. I shall move to Github actions sooner than I expected. |
|
@kasium sorry about the delay. CI issues should now be fixed. Do you think you could rebase to let the tests run before we merge? Thanks ! |
|
@lafrech done |
|
Thank you so much! |
Closes #745