Skip to content

Conversation

@BradyPlanden
Copy link
Contributor

Fall back to external functions when LLVM intrinsics are unavailable. I'm not sure what the best way to test this within the crate is. Any suggestions would be appreciated!

@martinjrobins
Copy link
Owner

Thanks @BradyPlanden, for a test I would just add a test for the tan function somewhere here:

exp_function: "r { exp(2) }" expect "r" vec![f64::exp(2.0)],
.

This should fail for llvm < 19 before your fix, and pass afterwards.

@BradyPlanden
Copy link
Contributor Author

Thanks @martinjrobins, I've tested on main locally and can confirm the additional tan test fails with cargo test --features llvm18-1

@martinjrobins martinjrobins merged commit b7f81d8 into martinjrobins:main Jan 2, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants