Getting rid of unused parameter ‘lest_env’ [-Werror=unused-parameter]#64
Merged
martinmoene merged 2 commits intomartinmoene:masterfrom Aug 23, 2018
medithe:patch-1
Merged
Getting rid of unused parameter ‘lest_env’ [-Werror=unused-parameter]#64martinmoene merged 2 commits intomartinmoene:masterfrom medithe:patch-1
unused parameter ‘lest_env’ [-Werror=unused-parameter]#64martinmoene merged 2 commits intomartinmoene:masterfrom
medithe:patch-1
Conversation
In the test-file `lest_cpp03.hpp`, the parameter `lest_env` may be not used in the expansion of the macro `lest_CASE`.
The full warning:
In file included from build/optional-lite-src/test/optional-main.t.h:18,
from build/optional-lite-src/test/optional-main.t.cpp:8:
build/optional-lite-src/test/optional-main.t.cpp: In function ‘void __lest_function__26(lest::env&)’:
build/optional-lite-src/test/lest_cpp03.hpp:266:43: error: unused parameter ‘lest_env’ [-Werror=unused-parameter]
static void lest_FUNCTION(lest::env & lest_env)
~~~~~~~~~~~~^~~~~~~~
build/optional-lite-src/test/optional-main.t.h:22:22: note: in expansion of macro ‘lest_CASE’
#define CASE( name ) lest_CASE( specification(), name )
^~~~~~~~~
build/optional-lite-src/test/optional-main.t.cpp:26:1: note: in expansion of macro ‘CASE’
CASE( "__cplusplus" "[.stdc++]" )
martinmoene
reviewed
Aug 22, 2018
include/lest/lest_cpp03.hpp
Outdated
| #elif defined __GNUC__ | ||
| #define lest_MAYBE_UNUSED(ARG) ARG __attribute((unused)) | ||
| #else | ||
| #define lest_MAYBE_UNUSED(ARG) |
Owner
There was a problem hiding this comment.
Add missing ARG:
#define lest_MAYBE_UNUSED(ARG) ARG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the test-file
lest_cpp03.hpp, the parameterlest_envmay be not used in the expansion of the macrolest_CASE.The full warning: