Skip to content

Conversation

@RachidTagzen
Copy link
Contributor

@RachidTagzen RachidTagzen commented Feb 21, 2025

When enabled, this feature "Hide disabled feeds" will automatically filter out and hide any disabled feeds from the feed list, providing a cleaner and more streamlined view for users. This enhancement will improve usability by reducing clutter and allowing users to focus only on active feeds.

NB : This feature works seamlessly as a complementary addition to the other committed features, such as Strikethrough and Custom color options Together, these options provide users with a comprehensive set of tools to customize and manage their feed list effectively, catering to different preferences and workflows.

1 - Setting

Enabled Disabled
2 - B_1 2 - B_2

@martinrotter
Copy link
Owner

martinrotter commented Mar 3, 2025

Sorry, I checked this PR and cannot accept it because the filtering is done in a "weird" way by playing with indexes.

Filtering must be done in FeedsProxyModel which is specifically meant for these things, specifically the filterAcceptsRowInternal method.

Also, I planned to make feed filtering work the same way as article filtering which has this nice multi-selection filtering popup dialog in article toolbar.

rssguard_XfxQoEJ4c9

So my other recommendation is this: when wanting to make some PR, please consult with me first to better align the PR with my view on the particular feature to be implemented etc. because there are many "internal" things I follow when programming RSS Guard which make code more simple, maintainable etc.

@RachidTagzen
Copy link
Contributor Author

That's fine. Anyway I'm much more interested in the RTL feature than hiding disabled feeds.
Thank you for the feedback and the recommendation. I understand the importance of aligning PRs with your vision for RSS Guard, especially regarding internal structures for simplicity and maintainability.
To be honest, I'm still relatively new to the GitHub PR process and I may encounter challenges and misunderstandings, so I'm definitely open to feedbacks.
Also, I'd appreciate knowing the best way to consult with you before submitting a PR. Would you prefer communication through GitHub discussions, email, or another platform?
Thanks again.

@martinrotter
Copy link
Owner

Hi, well, yes, either create discussion topic here, or you can (maybe for faster response) contact me via RSS Guard discord channel.

https://discord.gg/7xbVMPPNqH

@martinrotter
Copy link
Owner

This was basically added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants