Don't link pthread on Android

[gruberb]

No description provided.

[martinthomson]

Hi @gruberb, do you know of a way to test this effectively? I haven't wired up CI for android here, so I'm a little reluctant to take a change like this without some confirmation that it's safe. Have you tested this with Fenix?

[gruberb]

Hey @martinthomson. Yeah, we are currently trying to integrate ohttp into application-services and the CI for Fenix crashed because of the missing lpthread library. With the recent commit, the CI runs fine for Fenix.

I put it in Draft because of that. I am not sure currently how to make sure everything works as before. Maybe we keep it in this branch/commit and run it through a full cycle, or we find another way to test this.

[bendk]

Getting this to work in the app-services taskcluster CI took some investigation, but I think I was able to figure it out. Removing the -lpthreads worked, but then we ran into a second issue when trying to run bindgen to generate the Rust files for the NSS header files. That failed when trying to cross-compile for Darwin. I needed to add some flags so that bindgen could see the OSX header files. After that it everything seems to be working okay.

mozilla/application-services#7040

[martinthomson]

Thanks for confirming. Let me know that you are ready to proceed by marking this ready for review (it looks like it is already).

[martinthomson]

LGTM

[gruberb]

Can you run the workflow once more @martinthomson? Should be all good to go now! Thanks!