Many changes made pls read, or dont, whatever#100
Merged
martykan merged 21 commits intomartykan:masterfrom Jul 7, 2018
TacoTheDank:patch-1
Merged
Many changes made pls read, or dont, whatever#100martykan merged 21 commits intomartykan:masterfrom TacoTheDank:patch-1
martykan merged 21 commits intomartykan:masterfrom
TacoTheDank:patch-1
Conversation
updated to more recent things
ima just put all these strings in alphabetical order cause every strings.xml file i go to has them in different orders
gonna do a new release i guess
updated f-droid badge link
replace keepvid with ytbmp4.com the ytbmp3 and ytbmp4 sites (hosted by the same person) both use the youtube-dl method and is SUPER fast and no im not sponsored by ytbmp3/4 lmao, the [two] guys who run them rely on only non-intrusive ads to keep the site up, and im not affiliated with them in any way lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some translations that were missing (via Android Studio); replaced pt-BR with pt-rBR; put the strings in alphabetical order (using GitHub) because a few of them were in weird orders and some different spacing, and was confusing. You can change them all to the order you want them in later, or you can tell me how you want them and ill do it instead, since i did kinda fuck up the order you had them in, but to be fair i had no reference point to fix the rest from because they were all slightly different lol
updated the f-droid link in the README.md (doesnt really matter, but still) and deleted some extra spaces that were there
updated build.gradle and the dependencies; replaced the deprecated "compile" with "implementation" (check whether they should be api or implementation because im not sure); made a new release in build.gradle because updated translations and also f-droid is behind and also because why not
replaced keepvid with ytbmp4 (read commit notes for info)
if having the strings in alphabetical order bothers you, tell me how you want them so i can do that (or you can do it yourself if you feel like it), and then tag the 1.1.2 release if the build works
if it doesnt bother you, then just tag 1.1.2
also circleci 1.0 is gonna stop soon, youll need to update it to 2.0 (so circleci says)