feat: Support collection group#181
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for Firestore collection group operations across parsing, execution, tab-completion, tests, and documentation, enabling queries/counts that target all collections with a given collection ID across the DB hierarchy.
Changes:
- Introduces a
COLLECTION_GROUPkeyword/token and parsing support forQUERYandCOUNT. - Extends
QueryOperation/CountOperationto track collection-group mode and updates the executor to run collection-group queries. - Updates docs and adds parser/executor/completer test cases for collection-group usage.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| token.go | Adds COLLECTION_GROUP token/keyword mapping. |
| parser.go | Parses QUERY/COLLECTION_GROUP <id> and COUNT/COLLECTION_GROUP <id>; validates group name. |
| parser_test.go | Adds parse tests for collection-group query/count. |
| operation.go | Adds collectionGroup flag + constructors/accessors for query/count operations. |
| executor.go | Executes collection-group query/count paths in Firestore. |
| executor_test.go | Adds executor tests for collection-group query/count behavior. |
| docs/operations.md | Documents collection-group syntax, examples, and constraints. |
| completer.go | Adds COLLECTION_GROUP completion support for query/count. |
| completer_test.go | Adds completion tests around COLLECTION_GROUP keyword flows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8e51388 to
d4b1cbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.