Improve documentation, improve security, improve Scripts/mas & cleanup code#1238
Improve documentation, improve security, improve Scripts/mas & cleanup code#1238rgoldberg merged 6 commits intomas-cli:mainfrom
Scripts/mas & cleanup code#1238Conversation
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
rgoldberg
added
the
cleanup
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the DownloadQueueObserver to return from the task when self is nil and includes minor reformatting in CatalogApp.swift. Feedback was provided regarding the placement of the editorconfig-checker-disable-next-line comment, as moving it to the end of a line may prevent the linting tool from correctly suppressing line-length violations.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a SECURITY.md file, adds a comprehensive 'Outdated-App Detection' section to the README.md explaining various configuration flags, and refactors the mas script for improved path handling and error reporting. It also includes a fix for a task lifecycle issue in the download observer. Review feedback focuses on correcting a broken link in the security policy, ensuring Markdown files adhere to the 80-character line length limit specified in the style guide, and properly formatting linter directives.
rgoldberg
force-pushed
the
7.0.0/1237-cleanup
branch
from
5e08d63 to
dfb08e9
Compare
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
rgoldberg
force-pushed
the
7.0.0/1237-cleanup
branch
from
dfb08e9 to
5bc13cd
Compare
rgoldberg
changed the title
README.md, improve security, improve Scripts/mas & cleanup code
rgoldberg
added
the
chore
Improve existing documentation in `README.md`, `AGENTS.md` & `GEMINI.md`. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
rgoldberg
force-pushed
the
7.0.0/1237-cleanup
branch
from
5bc13cd to
caec297
Compare
|
rgoldberg
changed the title
README.md, improve security, improve Scripts/mas & cleanup codeScripts/mas & cleanup code
1 participant
README.md.README.md,AGENTS.md&GEMINI.md.SECURITY.md.Scripts/mas.Resolve #1237