Fix bug in local Euclidean distance calculation for fast implementation #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: masadcv <muhammad.asad@kcl.ac.uk>
Signed-off-by: masadcv <muhammad.asad@kcl.ac.uk>
Signed-off-by: masadcv <muhammad.asad@kcl.ac.uk>
Owner
Author
|
Using the code from #40 with modification to add GeodisTK results, here is comparison of 3d Euclidean distance with the bug: And here are results with fixes from this PR: With the PR, the Euclidean distances improve and is in-line with Euclidean distance from previous raster scan methods (e.g. using GeodisTK). It, however, is an approximation and unavoidable artifacts are present which are due reliance of these methods on iterative raster scans for distance transform computation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #40 , the only Euclidean case appeared to be computing taxicab distance.
On closer look, it came down to bug in local distance calculation
This PR attempts to fix this.