refactor: improve URL validation in NavigationUrlHelper#807
Merged
Qinyouzeng merged 9 commits intomainfrom Mar 26, 2026
Merged
Conversation
Contributor
wzh425
commented
Mar 26, 2026
wzh425
commented
- Added checks to ensure URLs start with "http://" or "https://" before processing.
- Enhanced the overall robustness of the URL building logic by validating input URLs.
…onents - Added Sapp client references and services in various components. - Enhanced navigation components to support Sapp-specific features, including maintenance status display and icon handling. - Updated localization files to include "InMaintenance" messages for multiple languages. - Adjusted layout and styling for Sapp navigation integration. - Improved I18nCache to handle Sapp navigation configurations.
- Updated exception handling to log warnings when remote data retrieval fails, ensuring the popover remains renderable. - Changed method signature of ConvertForNav to static for better performance and clarity.
…gationSapp component - Replaced direct favorite fetching and recent visit retrieval methods with helper methods from GlobalNavigationInteractionHelper for improved code clarity and maintainability. - Updated the logic for adding and removing favorites to utilize the new helper methods, enhancing consistency across the component.
…tack.Components into feature/sapp-global-nav
… streamline favorite management in GlobalNavigationSapp - Added logic to parse navigation types in ExpansionAppWrapper for improved type validation. - Updated GlobalNavigationSapp to utilize helper methods for fetching favorites and recent visits, enhancing code clarity and maintainability.
…igationUrlHelper - Replaced the existing URL building logic with a call to NavigationUrlHelper.BuildHref for improved clarity and maintainability. - This change enhances the handling of navigation URLs by leveraging existing helper methods.
- Added checks to ensure URLs start with "http://" or "https://" before processing. - Enhanced the overall robustness of the URL building logic by validating input URLs.
|
Qinyouzeng
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.