Fix import issue for non-main packages#100
Open
pistatium wants to merge 1 commit into
Open
Conversation
Owner
|
Thank you for your contribution! Your changes look good, but you probably don’t need to add a new test case since there’s already a test that checks the import of the time package: Once again, I appreciate your effort in fixing this issue. Thank you! |
Author
|
Thank you for your review and for pointing that out. I overlooked the existing test case. It indeed appears to be working correctly, and I was unable to write a test case that reliably reproduces the issue on my end. Since I cannot be entirely sure that my changes fully resolve the problem, I will take some time to investigate further. I appreciate your patience and guidance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses the issue where the generated code for non-main packages does not correctly import the required time package, leading to a build failure. Additionally, a test case using the time package has been added to ensure proper generation and functionality.
Changes:
• Fixed import handling for non-main packages in the generated code.
• Added a test case that utilizes the time package to verify correct behavior.
Related Issue:
• Fixes #95
Please review the changes, and let me know if any modifications are needed.
Thank you for your time!