Skip to content

https://github.com/masesgroup/KNet/issues/1238#issuecomment-3589708167: apply modifications requested#1239

Merged
masesdevelopers merged 1 commit intomasterfrom
1238-fix-issues-introduced-with-1224
Nov 28, 2025
Merged

https://github.com/masesgroup/KNet/issues/1238#issuecomment-3589708167: apply modifications requested#1239
masesdevelopers merged 1 commit intomasterfrom
1238-fix-issues-introduced-with-1224

Conversation

@masesdevelopers
Copy link
Contributor

Description

Apply modifications requested meanwhile the behavior of KNetRun.sh was changed splitting the code between standalone and any other run mode

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@masesdevelopers masesdevelopers self-assigned this Nov 28, 2025
@masesdevelopers masesdevelopers added bug Something isn't working Docker KNet related issue labels Nov 28, 2025
@masesdevelopers masesdevelopers linked an issue Nov 28, 2025 that may be closed by this pull request
@masesdevelopers masesdevelopers merged commit 6b4f00d into master Nov 28, 2025
90 of 92 checks passed
@masesdevelopers masesdevelopers deleted the 1238-fix-issues-introduced-with-1224 branch November 28, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Docker KNet related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix issues introduced with #1224

1 participant