Make RecordMetadata.DateTime nullable#1403
Merged
masesdevelopers merged 2 commits intomasterfrom Feb 28, 2026
Merged
Conversation
Return a nullable DateTime for RecordMetadata.DateTime and guard conversion with HasTimestamp(). This avoids producing a DateTime for records without a timestamp (returns null instead). Also updated the XML doc comment to reflect the nullable return and changed the conversion logic to only call Timestamp() when HasTimestamp() is true.
masesdevelopers
added
bug
Applies the fix of masesgroup/KEFCore#446 to avoid errors when executing some tests
masesdevelopers
deleted the
1402-timestamp-in-recordmetadata-does-not-exist-if-hastimestamp-is-false
branch
masesdevelopers
added a commit
that referenced
this pull request
Feb 28, 2026
* Make RecordMetadata.DateTime nullable Return a nullable DateTime for RecordMetadata.DateTime and guard conversion with HasTimestamp(). This avoids producing a DateTime for records without a timestamp (returns null instead). Also updated the XML doc comment to reflect the nullable return and changed the conversion logic to only call Timestamp() when HasTimestamp() is true. * Apply the fix for test execution on GitHub Applies the fix of masesgroup/KEFCore#446 to avoid errors when executing some tests
masesdevelopers
added a commit
that referenced
this pull request
Feb 28, 2026
* Make RecordMetadata.DateTime nullable Return a nullable DateTime for RecordMetadata.DateTime and guard conversion with HasTimestamp(). This avoids producing a DateTime for records without a timestamp (returns null instead). Also updated the XML doc comment to reflect the nullable return and changed the conversion logic to only call Timestamp() when HasTimestamp() is true. * Apply the fix for test execution on GitHub Applies the fix of masesgroup/KEFCore#446 to avoid errors when executing some tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Return a nullable DateTime for RecordMetadata.DateTime and guard conversion with HasTimestamp(). This avoids producing a DateTime for records without a timestamp (returns null instead). Also updated the XML doc comment to reflect the nullable return and changed the conversion logic to only call Timestamp() when HasTimestamp() is true.
Related Issue
closed #1402
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: