Rewrite in Typescript: Tree #315
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaki-yama
commented
Jun 17, 2019
| onNodeToggle, | ||
| onNodeLabelClick, | ||
| toggleOnNodeClick, | ||
| /* eslint-enable @typescript-eslint/no-unused-vars */ |
Contributor
Author
There was a problem hiding this comment.
https://github.com/mashmatrix/react-lightning-design-system/pull/315/files#diff-b8e1116dcaaf4336c2da8bf811daa6c1L32
Before converting to TypeScript, propTypes were used in cleanProps() to avoid passing unnecessary props (like onNodeClick) to <div> element.
I couldn't replace it with TypeScript's types, so this is a workaround.
Contributor
Author
There was a problem hiding this comment.
If I don't do this, the following runtime warnings occur:
Warning: Unknown event handler property `onNodeClick`. It will be ignored.
Warning: Unknown event handler property `onNodeToggle`. It will be ignored.
Warning: Unknown event handler property `onNodeLabelClick`. It will be ignored.
Warning: React does not recognize the `toggleOnNodeClick` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `toggleonnodeclick` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
Contributor
Author
|
Closed because the last PR #342 had been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref. #289
TODO: after #314 is merged, change base branch to
3.0.