Rewrite in Typescript: Spinner #317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaki-yama
force-pushed
the
typescript-spinner
branch
from
cb1d516 to
c26166e
Compare
zaki-yama
commented
Jul 2, 2019
src/scripts/Spinner.tsx
Outdated
|
|
||
| render() { | ||
| const { container, ...props } = this.props; | ||
| const { container = true, size = 'small', ...props } = this.props; |
Contributor
Author
There was a problem hiding this comment.
@stomita
I quit using defaultProps and use destructuring assignment instead.
It works, but I couldn't make use of type check here, it means I can assign any value to both container and size.
If you know any good solution, please tell me.
zaki-yama
commented
Jul 2, 2019
stories/SpinnerStories.tsx
Outdated
| () => { | ||
| // TODO: After https://github.com/storybookjs/storybook/issues/4487 is solved, | ||
| // - Add `undefined` to sizeOptions. | ||
| // - Change '' to `undefined` in typeOptions. |
Contributor
Author
There was a problem hiding this comment.
The problem that I can't add { '(none)': undefined } to sizeOptions is because of addon-knobs' issue:
addon-knobs select should be able to have undefined options. · Issue #4487 · storybookjs/storybook
First I fixed the component logic itself to work properly if given empty string (b438ac3).
But I thought we shouldn't change the logic for the story.
Contributor
Author
|
Closed because the last PR #342 had been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref. #289
TODO: after #316 is merged, change base branch to 3.0.