Rewrite in Typescript: PageHeader #336
Conversation
| legend?: string; | ||
| title?: string | JSX.Element; | ||
| breadCrumbs?: Array<JSX.Element>; | ||
| leftActions?: JSX.Element; |
There was a problem hiding this comment.
Should leftActions also be type of JSX.Element | Array<JSX.Element>?
I found rightActions accepts both single object or an array of objects in story.
| tag?: keyof ReactHTML; | ||
| category?: 'body' | 'heading' | 'title'; | ||
| type?: 'small' | 'regular' | 'medium' | 'large' | 'caps'; | ||
| type?: 'small' | 'regular' | 'medium' | 'large' | 'caps' | 'label'; |
There was a problem hiding this comment.
Since there isn't slds-text-heading_label or slds-text-heading--label class in the SLDS document,
https://www.lightningdesignsystem.com/utilities/text/#Heading-Size-Large
It is in the current source code of SLDS,
https://github.com/salesforce-ux/design-system/blob/21b01368fc63db0cf53c077def1ebffd9bb4c64d/ui/utilities/text/_index.scss#L67
(Though it's deprecated)
And, original propTypes accept it: https://github.com/mashmatrix/react-lightning-design-system/blob/master/src/scripts/Text.js#L28
So I added it.
There was a problem hiding this comment.
<Text type='label'> is used in PageHeader's story: https://github.com/mashmatrix/react-lightning-design-system/blob/master/stories/PageHeaderStories.js#L59
zaki-yama
force-pushed
the
typescript-grid
branch
2 times, most recently
from
ec6bb03 to
dcadc5a
Compare
zaki-yama
force-pushed
the
typescript-page-header
branch
from
1a17fb5 to
55b3745
Compare
zaki-yama
force-pushed
the
typescript-grid
branch
from
dcadc5a to
ed08100
Compare
zaki-yama
force-pushed
the
typescript-page-header
branch
2 times, most recently
from
58c8421 to
1a17fb5
Compare
zaki-yama
force-pushed
the
typescript-page-header
branch
from
1a17fb5 to
cd70896
Compare
|
Closed because the last PR #342 had been merged. |
ref. #289
TODO: after #335 is merged, change base branch to 3.0