Remove Newtonsoft.Json dependency from Benchmarks project#17
Merged
masilver99 merged 2 commits intomasterfrom Sep 26, 2025
Merged
Conversation
Co-authored-by: masilver99 <14352629+masilver99@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Swap out Newtonsoft with the System.Text.Json
Remove Newtonsoft.Json dependency from Benchmarks project
Sep 26, 2025
masilver99
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #XX by replacing the unused Newtonsoft.Json dependency with System.Text.Json support.
Changes Made
Newtonsoft.Jsonpackage reference fromBenchmarks/Benchmarks.csprojAnalysis
Upon investigation, I found that:
Testing
This change eliminates a security vulnerability mentioned in the project documentation while maintaining full compatibility. Future JSON serialization needs can leverage the built-in System.Text.Json APIs without any additional dependencies.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.