feat: Add general PR comments support and refactor review creation#179
Merged
feat: Add general PR comments support and refactor review creation#179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📝 Summary
This PR enhances the GitHub plugin's review capabilities by adding support for general PR comments (issue comments not tied to code lines) and refactoring the draft review creation to use GHNetwork instead of raw subprocess calls. It also improves the AI review workflow to handle both code changes and text-based replies, with shortened UI button labels for better UX.
🔧 Changes Made
get_pr_general_comments()method using GraphQL to fetch PR-level comments (not attached to code)create_draft_review()to use GHNetwork abstraction instead of direct subprocess executionbuild_ai_review_prompt()to support both code changes and text repliesGET_PR_ISSUE_COMMENTSfor fetching general PR commentsGraphQLIssueCommentmodel and mapper for issue comment data transformation🧪 Testing
poetry run pytest)make test)titan-devAdded comprehensive unit tests for:
📊 Logs
✅ Checklist