Skip to content

refactor: Improve console logging control for Textual devtools#198

Merged
finxo merged 3 commits intomasterfrom
chore/remove_logs_in_console
Apr 7, 2026
Merged

refactor: Improve console logging control for Textual devtools#198
finxo merged 3 commits intomasterfrom
chore/remove_logs_in_console

Conversation

@finxo
Copy link
Copy Markdown
Collaborator

@finxo finxo commented Apr 7, 2026

Pull Request

📝 Summary

Refines the console logging configuration logic for the Textual TUI. When devtools mode is enabled, console logging remains active so textual console can receive logs. In all other modes (including debug), console logging is disabled since the TUI hides it anyway, keeping only file-based logging.

🔧 Changes Made

  • Changed console logging logic from elif not debug to else block
  • Console logging now disabled in all non-devtools modes (including debug mode)
  • Updated comments to clarify logging behavior in devtools vs standard modes
  • Simplified conditional structure for better readability

🧪 Testing

  • Manual testing with titan-dev
  • Unit tests added/updated (poetry run pytest)
  • All tests passing (make test)

Verified console logging behavior with and without devtools flag.

📊 Logs

  • No new log events

✅ Checklist

  • Self-review done
  • Follows the project's logging rules (no secrets, no content in logs)
  • New and existing tests pass
  • Documentation updated if needed

@finxo finxo self-assigned this Apr 7, 2026
@finxo finxo merged commit 0ab50a9 into master Apr 7, 2026
5 checks passed
@finxo finxo deleted the chore/remove_logs_in_console branch April 7, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant