Skip to content

fix(notes): refresh notes graph on reopen #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonreshetov merged 1 commit into from
Apr 24, 2026
+3 −7
Merged

fix(notes): refresh notes graph on reopen #751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/renderer/components/notes/graph/__tests__/loader.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ describe('loadNotesGraphIfNeeded', () => {
expect(getNotesGraph).toHaveBeenCalledOnce()
})

it('does not reload graph data when it already exists', () => {
it('reloads graph data when entering graph with cached data', () => {
const getNotesGraph = vi.fn()

loadNotesGraphIfNeeded(
Expand All @@ -21,6 +21,6 @@ describe('loadNotesGraphIfNeeded', () => {
getNotesGraph,
)

expect(getNotesGraph).not.toHaveBeenCalled()
expect(getNotesGraph).toHaveBeenCalledOnce()
})
})
6 changes: 1 addition & 5 deletions src/renderer/components/notes/graph/loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,8 @@ interface NotesGraphDataLike {
}

export function loadNotesGraphIfNeeded(
graphData: NotesGraphDataLike | null,
_graphData: NotesGraphDataLike | null,
getNotesGraph: () => unknown,
) {
if (graphData) {
return
}

getNotesGraph()
}