Emit useful errors when encountering type 'any' in HCL#21
Merged
chrisghill merged 3 commits intomainfrom Jul 11, 2025
Merged
Conversation
coryodaniel
approved these changes
Jul 11, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error reporting for HCL variables of type any (and empty types) and ensures hydration functions propagate informative errors.
- Added explicit checks for empty and
anytypes invariableTypeStringToCtyType, with descriptive error messages. - Refactored hydration helpers to return errors for unsupported/dynamic types and wrapped errors with contextual information.
- Updated tests to assert expected error messages for both top‐level and nested
anyscenarios and added corresponding test fixtures.
Comments suppressed due to low confidence (2)
pkg/opentofu/tofutoschema_test.go:20
- [nitpick] Consider adding a test case for an empty variable type to cover the new
type cannot be emptyerror branch invariableTypeStringToCtyType.
tests := []testData{
pkg/opentofu/tofutoschema.go:168
- This call duplicates the hydration already performed by
hydrateArraySchema. Consider removing this second invocation and rely onhydrateArraySchemato initializesch.Itemsbefore settingUniqueItems.
return hydrateSchemaFromNameTypeAndDefaults(sch.Items, "", ty.ElementType(), getDefaultChildren(name, defaults))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.