Fix: Display Issue of Child Menu Items#1069
Merged
abdullai-t merged 2 commits intomainfrom Jun 24, 2024
Merged
Conversation
Enhanced portal navigation menus by introducing the `is_published` field. This will allow for better management of display settings.
refactor: Skip children if parent menu is disabled The code in `api_utils.py` has been refactored to improve readability and efficiency. Unpublished items are now directly skipped during iteration, which simplifies the logic and can potentially reduce unnecessary processing of children.
abdullai-t
changed the title
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1069 +/- ##
==========================================
- Coverage 54.01% 54.00% -0.01%
==========================================
Files 430 430
Lines 32034 32036 +2
==========================================
- Hits 17302 17300 -2
- Misses 14732 14736 +4 ☔ View full report in Codecov by Sentry. |
abdullai-t
changed the title
abdullai-t
requested review from
BradHN1,
Opoku-Agyemang,
archx3 and
frimpongopoku
2 tasks
abdullai-t
changed the title
archx3
approved these changes
Jun 24, 2024
archx3
approved these changes
Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / Highlights
This Pull Request addresses a specific issue where child menu items were being displayed even when their parent menu item was disabled. The changes introduced in this PR ensure that child menu items adhere to the visibility status of their parent menu item. After merging this PR, child menu items will only be displayed if their parent menu item is enabled, enhancing the consistency and usability of our navigation menus.
Details (Give details about what this PR accomplishes, include any screenshots etc)
Testing Steps (Provide details on how your changes can be tested)
Requirements (place an
xin each[ ])Transparency (Project board)