This repository was archived by the owner on Jun 26, 2018. It is now read-only.
DP-6712 Fix the Video Dimensions on the Service Detail Page #674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The container for video,
.ma__video, and iframe,.ma__iframe, didn't have the styles which other content container in the main column have:This was causing to iframe and video to stretch to fill its parent container when the side column content is not available.
Those missing styles are added to
.ma__videoand.ma__iframeto maintain the same width as other content in the main column.Related Issue / Ticket
Steps to Test
Note: Even the change is made in Mayflower, you don't see it in the sample pages set up in Mayflower. You need to test it in Drupal.
5.10.1-alpha-67124..ma__iframe, you'll find the following styles:.ma__video, you'll find the following styles:Note:
Videos are adjusted to fit in the given space for their widths and heights, but iframe are not. When the linked content (the page in the iframe) is bigger than the .ma__iframe (= iframe size), users need to use iframe's scroll bars to see overflow content. This is the same condition seen in mobile in the current production.
Screenshots
Before

After

Additional Notes:
Anything else to add?
Impacted Areas in Application
@todo
Today I learned...