This repository was archived by the owner on Jun 26, 2018. It is now read-only.
Add contact row organism #841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {% set compHeading = contactRow.compHeading %} | ||
| {% include "@atoms/04-headings/comp-heading.twig" %} | ||
|
|
||
| {% if contactRow.image %} |
Contributor
There was a problem hiding this comment.
Maybe a contactImage block around the if statement?
Contributor
There was a problem hiding this comment.
If the block and if are switched, I won't need to pass in an image: true to the component. I believe that would be better unless I am missing something ...
{% block contactImage %}
{% if contactRow.image %}
...
| {% endif %} | ||
|
|
||
| <div class="ma__contact-row__primary"> | ||
| {% block primaryContactGroup %} |
Contributor
There was a problem hiding this comment.
Primary contact is not required. Should you place an if around this and the wrapper? It might be good to have a variant without the primary contact group defined in the JSON to make it more clear that it is handled.
|
|
||
| {% if contactRow.moreLink %} | ||
| {% block moreLink %} | ||
| <div class="ma__contact-row__more-info"> |
Contributor
There was a problem hiding this comment.
Can the block go inside the div so that I don't have to copy the wrapper to Drupal when implementing?
| </div> | ||
| {% endif %} | ||
|
|
||
| {% if contactRow.moreLink %} |
Contributor
There was a problem hiding this comment.
I want to check with Joe first, but I think this whole section might need to be inserted between lines 30 and 31.
isaacchansky
force-pushed
the
DP-8992-8993-8969-contact-row
branch
from
1e283f6 to
ea6e445
Compare
clair0917
approved these changes
May 29, 2018
Contributor
clair0917
left a comment
clair0917
left a comment
There was a problem hiding this comment.
Other than Nathan's comment, this looks good to me
* dev: (21 commits) DP-6907 change default ordered list type styling in rich text fields (#849) DP-8574 jQuery update for Firefox sticky TOC bug (#822) DP-9010 update row order for board pages (#851) Update snapshot after merge conflict Changelog, snapshot update, and updated comment Update press release with image to responsive Move to versions of the image for srcset Updated the package.json version to 5.25.0 Removed changelogs txt files for 5.25.0 Added release notes for 5.25.0 DP-9057: replace display initial for IE11 compatibility (#843) DP-8854: Adjust capitalization in Mass.gov service mark in footer (#846) DP-8854: Adjust site footer for use outside of Pattern Lab (#834) DP-8631 - Provides twig blocks to support overrides and template mapping of data. (#789) Update image to allow srcset and sizes DP-8949 subpatterns for general teaser (#837) Updated the package.json version to 5.24.0 Removed changelog txt file for 5.24.0 Added release notes for 5.24.0 Contact us: Show more style with only 2 items ...
* dev: DP-8897: replace the incorrectly pushed backstop files DP-8897: updates to backstop files update package.json file rm old change notes update changelog file DP-8897: updates to mobile layout DP-8897: backstop files DP-8897: update some comments for better explinations DP-8897: Adds relationship indicator pattern with styles and functionality and adds to org MF page for review
isaacchansky
added a commit
that referenced
this pull request
Jun 8, 2018
* dev: (22 commits) Updating reference screenshots Updating reference screenshots update the version for release-5.27.0 in package.json update release-notes.md for Release-5.27.0 DP-8992: Add contact row organism (#841) DP-8897: replace the incorrectly pushed backstop files DP-8897: updates to backstop files update package.json file rm old change notes update changelog file DP-8897: updates to mobile layout DP-6907 change default ordered list type styling in rich text fields (#849) DP-8897: backstop files DP-8897: update some comments for better explinations DP-8897: Adds relationship indicator pattern with styles and functionality and adds to org MF page for review DP-8574 jQuery update for Firefox sticky TOC bug (#822) DP-9010 update row order for board pages (#851) Update snapshot after merge conflict Changelog, snapshot update, and updated comment Update press release with image to responsive ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any PRs being created needs a changelog.txt file before being merged into dev. See: Change Log Instructions
Description
This PR adds a new 'contact row' organism to alleviate some issues with the contact list organism being used in certain new contexts.
Related Issue / Ticket
https://jira.state.ma.us/browse/DP-8993
https://jira.state.ma.us/browse/DP-8992
https://jira.state.ma.us/browse/DP-8969
Steps to Test
View component is isolation http://localhost:3000/?p=organisms-contact-row
and variations:
Confirm that spacing and positioning issues from the following are not present:
Screenshots
Additional Notes:
Anything else to add?
Impacted Areas in Application