mock heavy utils import#8317
Merged
OmarZubaidi merged 2 commits intoJun 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the candidApi helper unit test to avoid importing/spreading the real utils package entrypoint (which can be heavy), by replacing the importOriginal-based mock with a fully self-contained vi.mock('utils', ...) factory.
Changes:
- Replace
vi.mock('utils', async (importOriginal) => ({ ...actual, ... }))with a lightweight mock that does not import the original module. - Add additional mocked exports (
MISSING_REQUEST_SECRETS,SecretsKeys) needed bycandidApi.tswhen importing fromutils.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Omar Zubaidi <66521244+OmarZubaidi@users.noreply.github.com>
alexwillingham
approved these changes
Jun 22, 2026
OmarZubaidi
deleted the
omar/otr-2848-fix-test-flake-libhelperscandidapitestts
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.