Conversation
Sync: develop with main
Fix issue 9 v2
📝 WalkthroughWalkthroughThis PR adds support for five new languages (Bengali, Gujarati, Punjabi, Swahili, and Urdu) to the SafeText package by introducing corresponding data assets, extending the Language enum with new variants, updating documentation to reflect expanded language coverage from 75+ to 80+ supported languages, and bumping the version to 2.1.2. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
CHANGELOG.md (1)
5-5: Clarify the language count wording.The phrase "82 supported languages (including
Language.all)" is ambiguous. SinceLanguage.allis a meta-value that represents all languages rather than a language itself, consider rephrasing to:
- "82 supported languages, plus
Language.allfor convenience"- or simply "82 supported languages"
This prevents confusion about whether
Language.allis counted as one of the 82 languages.📝 Suggested wording improvement
-- Language count now reaches **82 supported languages** (including `Language.all`). +- Language count now reaches **82 supported languages**, plus `Language.all` for loading all languages at once.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@CHANGELOG.md` at line 5, Update the CHANGELOG wording to avoid counting the meta-value `Language.all` as a language: replace "Language count now reaches **82 supported languages** (including `Language.all`)." with a clearer phrase such as "**82 supported languages**, plus `Language.all` for convenience" or simply "**82 supported languages**" so `Language.all` is not implied as one of the 82; ensure the change references the `Language.all` symbol in the explanatory text.README.md (1)
17-17: Consider using consistent language count.Line 17 says "80+ languages" while line 266 says "82 supported languages". Since the exact count is now 82 (77 original + 5 new), consider updating all references to use the precise count for consistency. This also applies to lines 49 and 427.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` at line 17, Documentation inconsistency: replace all occurrences of the approximate "80+ languages" phrasing with the precise "82 supported languages" to match the updated count; search for strings like "80+ languages", "80 +" and the sentence mentioning "82 supported languages" (e.g., the paragraph starting "A high-performance Flutter package..." and the other mentions near lines 49 and 427) and update them to consistently state "82 supported languages".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 459: Replace the staging contributors badge URL with the production URL
by changing the img src value
"https://stg.contrib.rocks/image?repo=master-wayne7/safe_text" to
"https://contrib.rocks/image?repo=master-wayne7/safe_text" in the README's
contributors badge tag so the badge points to the stable production endpoint.
---
Nitpick comments:
In `@CHANGELOG.md`:
- Line 5: Update the CHANGELOG wording to avoid counting the meta-value
`Language.all` as a language: replace "Language count now reaches **82 supported
languages** (including `Language.all`)." with a clearer phrase such as "**82
supported languages**, plus `Language.all` for convenience" or simply "**82
supported languages**" so `Language.all` is not implied as one of the 82; ensure
the change references the `Language.all` symbol in the explanatory text.
In `@README.md`:
- Line 17: Documentation inconsistency: replace all occurrences of the
approximate "80+ languages" phrasing with the precise "82 supported languages"
to match the updated count; search for strings like "80+ languages", "80 +" and
the sentence mentioning "82 supported languages" (e.g., the paragraph starting
"A high-performance Flutter package..." and the other mentions near lines 49 and
427) and update them to consistently state "82 supported languages".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ab835179-c751-40ed-9b16-2c50ca1c773e
📒 Files selected for processing (9)
CHANGELOG.mdREADME.mdassets/data/bn.txtassets/data/gu.txtassets/data/pa.txtassets/data/sw.txtassets/data/ur.txtlib/src/models/language.dartpubspec.yaml
| <p align="center"> | ||
| <a href="https://github.com/master-wayne7/safe_text/graphs/contributors"> | ||
| <img src="https://contrib.rocks/image?repo=master-wayne7/safe_text" alt="Contributors" /> | ||
| <img src="https://stg.contrib.rocks/image?repo=master-wayne7/safe_text" alt="Contributors" /> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if the new URL is accessible and returns valid content
echo "=== Testing new contributors badge URL ==="
curl -I "https://stg.contrib.rocks/image?repo=master-wayne7/safe_text" 2>&1 | head -n 5
echo ""
echo "=== Testing original URL for comparison ==="
curl -I "https://contrib.rocks/image?repo=master-wayne7/safe_text" 2>&1 | head -n 5Repository: master-wayne7/safe_text
Length of output: 887
Use the stable production URL for the contributors badge.
The contributors badge URL uses stg.contrib.rocks (staging environment) instead of the stable production URL contrib.rocks. While both URLs are currently accessible, using a staging URL in production documentation is not recommended as it may be subject to change. Update line 459 to use https://contrib.rocks/image?repo=master-wayne7/safe_text.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` at line 459, Replace the staging contributors badge URL with the
production URL by changing the img src value
"https://stg.contrib.rocks/image?repo=master-wayne7/safe_text" to
"https://contrib.rocks/image?repo=master-wayne7/safe_text" in the README's
contributors badge tag so the badge points to the stable production endpoint.
Description
What does this PR do?
Updates the package version to 2.1.2 with adding 5 more languages to data set
Related Issue
Closes #9
Summary by CodeRabbit
New Features
Documentation