fix(transcribe): no ffmpeg console flash + persist run state across tab switches#13
Merged
Conversation
…ches Two UX bugs from real-file testing: 1. ffmpeg flashed a console window on every Transcribe. The GUI app runs with windows_subsystem="windows" (no console), so spawning ffmpeg popped a visible console for its lifetime. Add a `no_window_command` helper that sets CREATE_NO_WINDOW on Windows; use it for both ffmpeg spawns. 2. Switching settings tabs mid-transcription reset the Transcribe File UI and hid progress — all run state lived in component-local useState, lost on unmount; the orphaned run() kept going but its result/file-write was tied to the dead component. Lift the inputs + run state + run()/cancel() into a zustand store (src/stores/transcribeStore.ts) so a long run stays visible (progress, result, saved-to) after navigating away and back. Listeners now live for the run's lifetime in the store, not the component. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
master5d
added a commit
that referenced
this pull request
Jun 3, 2026
Ships the Transcribe File UX fixes (#13): no ffmpeg console-window flash on Windows, and run state (progress/result/saved-to) persisted in a store so a long transcription survives switching settings tabs. First release after the win-arm64 target drop (#12), so all 7 targets should be green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
master5d
added a commit
that referenced
this pull request
Jun 3, 2026
Bundles the Transcribe File UX fixes (#13: no ffmpeg console flash, run state persisted across tab switches) and the speaker-grouped output format (#14: `[Speaker N] (M:SS - M:SS)` blocks, CLI `--format speaker`, diarization-CLI hint) into one release. (Supersedes the unpublished v1.1.3 draft.) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two UX bugs surfaced transcribing a real 40-min file:
ffmpegis spawned from awindows_subsystem="windows"GUI app (no console of its own), so the child popped a visible console.useState, lost on unmount; the orphanedrun()kept going but its result/file-write was tied to the dead component instance — so a long transcription could finish without the file ever being written or shown.What
no_window_commandhelper (file_transcription.rs) that setsCREATE_NO_WINDOWon Windows; use it for both ffmpeg spawns. No-op on other platforms.run()/cancel()into a zustand store (src/stores/transcribeStore.ts). The component is now a thin view; progress/result/saved-to survive tab navigation, and the progress listeners live for the run's lifetime in the store rather than the component.Verification
tsc --noEmit,eslint,prettier@3.8.3 --check,cargo fmtall clean. The Rust helper is#[cfg(windows)]-gated (plainCommand::newelsewhere). Bundled for v1.1.3.🤖 Generated with Claude Code