Bugfix: Stale UDP connection pool eviction#75
Merged
Conversation
Updated UDP connection pooling to include connection age management. Changed the pool to store pooledUDPConn structs instead of UDPConn pointers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UDP connections to DNS resolvers are pooled for reuse. But after sitting idle for 60+ seconds, NAT middleboxes (very common on Iran ISPs) may expire the port mapping. The connection's local ephemeral port is now dead — writes succeed (UDP is fire-and-forget), but responses from the resolver get routed to a closed port and silently vanish. This looks like a resolver being "lossy"
@masterking32 can you please double check the code ? looks right on the paper but haven't tested this in production because of poor internet. thank you.