Remove unnecessary import #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Ah I see, you are a man of clean code, as well |
Contributor
Author
|
Indeed. I bath my code every once in a while. =) |
Contributor
Author
|
Because, you know, dirty code usually runs a little bit slower than the clean one. |
eladgel
pushed a commit
to HoneyBook/react-native-action-button
that referenced
this pull request
Oct 13, 2017
* commit 'a73637cca3f43fa07d065e48ca62e828e66f3da8': 2.8.0 Switch MainButton to use Margin not Padding, and fix shadow prop warning (mastermoo#212) Fix shadow style on Android (mastermoo#215) Make non-string value/component as title (mastermoo#211) Add reminder for linking `react-native-vector-icons`. (mastermoo#214) add props onPressIn and onPressOut (mastermoo#216) Remove unnecessary import (mastermoo#200) 2.7.2 Migrate deprecated React.PropTypes (mastermoo#195) 2.7.1 - revert some changes made in mastermoo#185 - use prettier on code 2.7.0 Package of fixes and new features (Read on): (mastermoo#185) 2.6.10 Update README.md Add support to hide ActionButtonItem and/or its label shadows # Conflicts: # ActionButton.js # ActionButtonItem.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Do we still need
Platformhere? It seems unnecessary to me since we already haveisAndroidfrom './shared' for that.