Fixed button shadow on Android 5+ #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 23, 2016
|
I tested in on iOS. It does not break the component, but it pushes the button a bit to the top. Why did give exactly 12 points margin bottom and not more or less? Is there a way to make it visible without adding margin? |
|
It seemed like 12 points was the right amount. I've tried playing around a little bit with the number now and it seems like 10 is the minimum until the shadow gets cropped. Unfortunately, I don't think there's a way to make it visible without adding the margin. Maybe you can shift the button a little bit to the bottom by the size of the margin? |
|
check out v2.0.0, i mentioned to in the commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed missing button shadow on Android 5+. It uses elevation style available in React Native. I had to add bottom margin to make it visible. The bottom margin might brake the look on iOS, I haven't tested it on iOS. Somebody, please, test it on iOS :) and tell me if it's ok... But I think it should be allright.