Skip to content

Pandafy data#4

Closed
florian-huber wants to merge 13 commits intomainfrom
pandafy_data
Closed

Pandafy data#4
florian-huber wants to merge 13 commits intomainfrom
pandafy_data

Conversation

@florian-huber
Copy link
Copy Markdown
Member

alternative route to same goal. Now using panda multiindex DataFrame underneath.

@florian-huber
Copy link
Copy Markdown
Member Author

florian-huber commented Sep 21, 2022

Up to this point:
The panda-based solution works as well.
Pros:

  • Code is more readable
  • Stacking arrays is much more flexible ("left", "right", "inner", "outer" joins are possible)
  • Stacking arrays is much faster.

Cons:

  • Slicing became much slower! --> Maybe adapt slicing more to pandas implementation?
    (one option might be to use df._values directly instead of going via .iloc)

@florian-huber
Copy link
Copy Markdown
Member Author

After a lot of profiling I decided against a Pandas implementation (too slow slicing) --> See #11 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant