fs_may19_olha#5
Closed
OlgaLyubicheva wants to merge 2 commits intomate-academy:masterfrom
OlgaLyubicheva:fs_may19_olha
Closed
fs_may19_olha#5OlgaLyubicheva wants to merge 2 commits intomate-academy:masterfrom OlgaLyubicheva:fs_may19_olha
OlgaLyubicheva wants to merge 2 commits intomate-academy:masterfrom
OlgaLyubicheva:fs_may19_olha
Conversation
mgrinko
reviewed
Jun 21, 2019
|
|
||
| if (arguments.length === 0) { | ||
| compare = sortLikeString; | ||
| } |
Contributor
There was a problem hiding this comment.
const compare = compareFunction || sortLikeString;
Author
There was a problem hiding this comment.
sortLikeString всегда будет true, а compareFunction принимать значение по ситуации (если undefined => false, другие => true) и останется только проверить является ли это "true" именно функцией. Понятно
mgrinko
reviewed
Jun 21, 2019
mgrinko
reviewed
Jun 21, 2019
mgrinko
suggested changes
Jun 21, 2019
Contributor
mgrinko
left a comment
mgrinko
left a comment
There was a problem hiding this comment.
Отличная работа!
Осталось чуть чуть подмарафетить
Author
|
спасибо :) |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.