solution#19
Closed
igor-kashchenko wants to merge 1 commit intomate-academy:masterfrom
igor-kashchenko:develop
Closed
solution#19igor-kashchenko wants to merge 1 commit intomate-academy:masterfrom igor-kashchenko:develop
igor-kashchenko wants to merge 1 commit intomate-academy:masterfrom
igor-kashchenko:develop
Conversation
GarryRocksman
approved these changes
Mar 12, 2023
GarryRocksman
left a comment
GarryRocksman
left a comment
There was a problem hiding this comment.
GJ 🔥 Just look at the comments, mayby you will finde something to fix
Comment on lines
+64
to
+81
| const markup = ` | ||
| <table> | ||
| <thead> | ||
| <tr> | ||
| <th>Title</th> | ||
| <th>Amount</th> | ||
| <th>Date</th> | ||
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| <tr> | ||
| <td>${title}</td> | ||
| <td>${amount}</td> | ||
| <td>${date}</td> | ||
| </tr> | ||
| </tbody> | ||
| </table> | ||
| `; |
There was a problem hiding this comment.
i suppouse we need just send well formated JSON ( acording to the task) , but nice sollution with table
| } | ||
|
|
||
| if (pathName === 'format') { | ||
| const form = new formidable.IncomingForm(); |
|
|
||
| fs.writeFileSync(JSONFile, jsonFields); | ||
|
|
||
| const file = fs.createReadStream(JSONFile); |
| @@ -0,0 +1 @@ | |||
| {"date":"asdas","title":"asdasd","amount":"asdads"} No newline at end of file | |||
There was a problem hiding this comment.
we need well formated JSON file, and question is - what if you sine form couple of times, new expenses will be added to file or it just overrrides every time?
ArturErmolenko
approved these changes
Jul 7, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.