Skip to content

Conversation

@pubiqq
Copy link
Contributor

@pubiqq pubiqq commented Apr 19, 2022

Context:

It did look like the Android framework string is missing on certain OEM devices. (Material is using android:string/ok for the button.) I guess we can fix it by replacing the string with proper values.


@dsn5ft
Copy link
Contributor

dsn5ft commented Apr 25, 2022

Thanks for the PR! Those translated files are somewhat autogenerated internally, so I'll update the source code and then the new translations will be synced out later.

@pubiqq
Copy link
Contributor Author

pubiqq commented Apr 25, 2022

OK, I will update my PR as soon as all the translations appear.

@pubiqq
Copy link
Contributor Author

pubiqq commented Apr 25, 2022

By the way, I noticed you partially added translations here and some of them differ from android:string/ok:

Resource @android:string/ok 431e291
values-as ঠিক আছে OK
values-hy Լավ Եղավ
values-ka OK კარგი
values-mr ठीक आहे ओके
values-or ଠିକ୍‍ ଅଛି OK

In these cases, the translations will differ both from the old MaterialDatePicker implementation and from android.app.DatePickerDialog. It's not critical, nevertheless, I would like to know if you will keep the current translations or will try to unify them with standard Android strings?

P. S. As for the correctness of the translations, I can't say anything, specifically for my PR I took them from Android SDK 31 sources.

@dsn5ft
Copy link
Contributor

dsn5ft commented Apr 26, 2022

No need to update this PR, we will automatically add the translations to the library when they are available internally.

We use a different translation service, so the specific translations will not always match whatever is in the AOSP source - we will not attempt to maintain consistency with that.

@pubiqq
Copy link
Contributor Author

pubiqq commented Apr 26, 2022

No need to update this PR, we will automatically add the translations to the library when they are available internally.

I meant "update" = "leave the relevant comment and close" 😄

... the specific translations will not always match whatever is in the AOSP source - we will not attempt to maintain consistency with that.

OK, thanks for the answer!

@dsn5ft
Copy link
Contributor

dsn5ft commented Apr 26, 2022

Ah! Gotcha. I will actually link your PR to my commit coming here soon and the PR will be auto-closed. The translations will be synced out automatically within a week or two I believe.

@pubiqq
Copy link
Contributor Author

pubiqq commented Apr 26, 2022

Oh, that's even better, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants