[Docs] Detailed description of code example for collapsing toolbar style#3915
Closed
cworld1 wants to merge 1 commit intomaterial-components:masterfrom
Closed
[Docs] Detailed description of code example for collapsing toolbar style#3915cworld1 wants to merge 1 commit intomaterial-components:masterfrom
cworld1 wants to merge 1 commit intomaterial-components:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
Emmm... What's wrong about this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it is necessary to add the specific
topAppBarprimary key description code to the code instance of collapsing toolbar style. Although this hint appeared in the normal toolbar style, it wasn't obvious enough that it took me hours to figure out what the problem was. Settinglayout_heightto another option causes the component to not work properly and the title to not display properly. Hopefully this new description will help others avoid this problem.