Skip to content

[TextInputLayout] run the captionViewToShow logic whenever there is a view #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
frett wants to merge 1 commit into from
Closed

[TextInputLayout] run the captionViewToShow logic whenever there is a view #528

frett wants to merge 1 commit into from

Conversation

@frett
Copy link
Contributor

@frett frett commented Aug 20, 2019 •
edited
Loading

Previously this logic would only run if there was also a captionViewToHide.
This led to the error message maintaining the -5dp translationY in my app because I was only showing the error message and not hiding any other helper message.

Thanks for starting a pull request on Material Components!

Don't forget:

  • Identify the component the PR relates to in brackets in the title.
    [Buttons] Updated documentation
  • Link to GitHub issues it solves. closes #1234
  • Sign the CLA bot. You can do this once the pull request is opened.

@frett
run the captionViewToShow logic whenever there is a view
55964e5 
Previously this logic would only run if there was also a captionViewToHide.
This led to the error message maintaining the -5dp translationY in my app.
@ldjcmu ldjcmu closed this in 4bd83e5 Sep 27, 2019
@frett frett deleted the textInputLayoutErrorFix branch September 27, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frett @googlebot @leticiarossi