[NavigationMenu] Don't rebind/relayout/reinflate any views after clicking a menu item #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If none of the check state has changed, let's not update the menu. Background for this diff is at material-components#61. While larger improvements may make sense, this diff is designed to mitigate the most serious issue in a way that doesn't create risk. Test: used these modified classes inside the Android Uber app and ran a profiler. The problematic 50ms delay caused by this bug was fixed. You can see the before/after traces in https://issuetracker.google.com/issues/73723207.
Contributor
Author
|
Travis is going to fail given that master has been red for a while. This doesn't mean anything is wrong with the diff. |
JakeWharton
reviewed
Feb 21, 2018
| updateMenuView(false); | ||
| } | ||
| } | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
Well. I feel silly.
Thanks for spotting that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If none of the check state has changed let's not update the menu. While larger improvements may make sense, this diff is designed to mitigate the most serious issue in a way that doesn't create risk.
Background for this diff is at #61. This diff should close the issue.
Test: used these modified classes inside the Android Uber app and ran a profiler. The problematic 50ms delay caused by this bug was fixed. You can see the before/after traces in https://issuetracker.google.com/issues/73723207.