fix(menu): blur focused descendant before setting aria-hidden#5948
Open
akinshaywai wants to merge 1 commit intomaterial-components:mainfrom
Open
fix(menu): blur focused descendant before setting aria-hidden#5948akinshaywai wants to merge 1 commit intomaterial-components:mainfrom
akinshaywai wants to merge 1 commit intomaterial-components:mainfrom
Conversation
When focus moves to another window or tab while a menu item is focused, the browser fires focusout on the menu item and the menu closes. During closing, aria-hidden="true" is set on the menu element but the browser blocks it because a descendant still retains focus, producing a console warning that violates WAI-ARIA guidelines. Blur any focused descendant before setting aria-hidden so the attribute is never applied to an element that contains a focused child. Fixes material-components#5760
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #5760
When a user opens a menu, focuses a menu item, then switches to another window or tab:
focusouton the focused<li>menu item (relatedTargetisnull)handleFocusoutcloses the menuwillUpdatesetsaria-hidden="true"on<md-menu>This violates WAI-ARIA guidelines and produces noise in the console.
Fix
Before setting
aria-hidden="true"inwillUpdate, check whetherdocument.activeElementis a descendant of the menu and blur it if so. This moves focus todocument.bodyfirst, allowingaria-hiddento be applied without triggering the browser warning.Testing
To reproduce before this fix:
After this fix the warning no longer appears.