Toggle button

[treeder]

• closes Toggle buttons #44

[gemini-code-assist]

Summary of Changes

Hello @treeder, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive toggle button functionality to the md-button component, addressing issue #44. It allows buttons to maintain a selected state, provides appropriate event handling for state changes, enhances accessibility through ARIA attributes, and includes distinct visual styling for both selected and unselected states across different button color variants. The changes provide a robust solution for interactive toggle buttons.

Highlights

• Toggle Button Functionality: Introduced toggle and selected properties to the md-button component, enabling it to function as a toggle button with distinct selected and unselected states.
• State Management and Events: Implemented logic within the handleClick method to manage the selected state of toggle buttons, flipping it on click and dispatching input and change events to notify listeners of state changes.
• Accessibility Enhancements: Added the aria-pressed attribute to the button's underlying HTML element, which dynamically reflects the selected state, improving accessibility for users of assistive technologies.
• Visual Styling for Toggle States: Incorporated new CSS styles to provide clear visual feedback for selected and unselected toggle buttons across various button types, including 'filled', 'tonal', 'elevated', 'text', and 'outlined'.
• Demo Page Update: Updated the demo component to include examples of the new toggle button functionality, making it easy to preview and test the new feature.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces toggle button functionality to the md-button component. The changes include adding toggle and selected properties, handling click events to toggle the state, and adding aria-pressed for accessibility. New CSS styles are also added for the various states and colors of toggle buttons.

My review includes a fix for an issue where the hover/pressed state layer on selected elevated toggle buttons would be invisible, and a suggestion to expand the demo page to include examples of all new toggle button variants for better testing and demonstration.