Remove asset manifest #662
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flutter no longer provides access to the
AssetManifest.jsonfile that google_fonts was depending on:https://docs.flutter.dev/release/breaking-changes/asset-manifest-dot-json
Instead Flutter provides an API to access this same information.
This was causing "AssetManifest.json not found" errors and test failures in other repos like dart-pad which depend on this package.
Tests
I've updated the tests to mock out the AssetManager API. We're only using the
listAssetsAPI here so this is just a matter of returning the correct List of strings for each test.Issues
Fixes # #661
Checklist
CHANGELOG.md