Skip to content

Conversation

@DanielRuf
Copy link

Proposed changes

This PR upgrades grunt-contrib-jasmine to v3, let's see if this fixes the test pipeline.

Screenshots (if appropriate) or codepen:

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DanielRuf DanielRuf changed the title test: upgrade grunt-contrib-jasmine to upgrade puppeteer test: upgrade grunt-contrib-jasmine to upgrade puppeteer and set version of jasmine Sep 18, 2021
@DanielRuf
Copy link
Author

I'm going forward and merge this.

@DanielRuf DanielRuf merged commit 8482ab0 into v1-dev Sep 18, 2021
@DanielRuf DanielRuf deleted the test/183-upgrade-grunt-contrib-jasmine branch September 18, 2021 20:13
@Smankusors Smankusors added the meta Issues with the project itself or our GitHub repository. label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues with the project itself or our GitHub repository.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants