Skip to content

Conversation

@gergo85
Copy link

@gergo85 gergo85 commented Jul 12, 2022

Remove the unnecessary spaces, fix links url and add meta tags, minor typo fixes.

@wuda-io
Copy link
Member

wuda-io commented Jul 12, 2022

Ok, the parts look good now.
Please change the commit-messages according to www.commitlint.io
Otherwise the merge cannot be completed.

@gergo85 gergo85 changed the title Improve the documentation refactor: improve the documentation Jul 12, 2022
@gergo85
Copy link
Author

gergo85 commented Jul 12, 2022

I modified it.

@Smankusors
Copy link
Member

it seems like we have misunderstanding about what "commit message" is... What we mean about commit messages, are messages from your 3 commits below

  • Remove the unnecessary spaces
  • Minor typo fixes
  • Fix links url and add meta tags

What you changed before is your "pull request title", not the "commit message".

@gergo85
Copy link
Author

gergo85 commented Jul 16, 2022

If that's not good. then I'll delete the pull request.

Copy link
Member

@Smankusors Smankusors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR is fine, just need a little fix (also you can't delete the PR once you create it) 😅

You can ammed the commit messages, instead of closing and reopened the new one. If you don't know how, please take a look at https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message#amending-older-or-multiple-commit-messages

While at it, I wonder what fc5edae is talking about. It's "Minor typo fixes", but I don't see any typos?

@gergo85
Copy link
Author

gergo85 commented Aug 3, 2022

I modified the commit name. I have no experience with git commands, so I hope I did well.

@Smankusors
Copy link
Member

Smankusors commented Aug 3, 2022

hmm not quite right

let's use your last commit as an example. Last time you commit with the message below

Change protocol to https:// from ://

when this should be like this below

chore: Change protocol to https:// from ://

or

refactor: Change protocol to https:// from ://

or you can replace the chore: or refactor: with anything else, as long as it's using <type>: <subject> format. So far do you understand what I mean?

@gergo85
Copy link
Author

gergo85 commented Aug 9, 2022

I hope it looks great.

@Smankusors Smankusors merged commit 42468a3 into materializecss:main Aug 11, 2022
@Smankusors
Copy link
Member

ah goddamnit, I made a mistake when trying to rewrite the history (so the existing commits are not repeated again). Alas GitHub recognized this as merged, while there are no commits that actually being merged 🤦

anyway, I will push the commits from my own PR instead. I also invited you to join to join as the member of materializecss 🎉

@Smankusors Smankusors added the documentation Improvements or additions to documentation label Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants