-
-
Notifications
You must be signed in to change notification settings - Fork 109
refactor: improve the documentation #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ok, the parts look good now. |
|
I modified it. |
|
it seems like we have misunderstanding about what "commit message" is... What we mean about commit messages, are messages from your 3 commits below
What you changed before is your "pull request title", not the "commit message". |
|
If that's not good. then I'll delete the pull request. |
Smankusors
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR is fine, just need a little fix (also you can't delete the PR once you create it) 😅
You can ammed the commit messages, instead of closing and reopened the new one. If you don't know how, please take a look at https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message#amending-older-or-multiple-commit-messages
While at it, I wonder what fc5edae is talking about. It's "Minor typo fixes", but I don't see any typos?
|
I modified the commit name. I have no experience with git commands, so I hope I did well. |
|
hmm not quite right let's use your last commit as an example. Last time you commit with the message below when this should be like this below or or you can replace the |
|
I hope it looks great. |
|
ah goddamnit, I made a mistake when trying to rewrite the history (so the existing commits are not repeated again). Alas GitHub recognized this as merged, while there are no commits that actually being merged 🤦 anyway, I will push the commits from my own PR instead. I also invited you to join to join as the member of materializecss 🎉 |
Remove the unnecessary spaces, fix links url and add meta tags, minor typo fixes.