Skip to content

Conversation

@nekonenene
Copy link

@nekonenene nekonenene commented Sep 20, 2020

Proposed changes

This PR reverts commit bafde66 because it breaks sidenav style.

It is better to understand the motivation for his change, but I don't have any way because this commit doesn't associated to any issues or pull requests, so I decided to simply revert.

Screenshots (if appropriate) or codepen:

In https://materializecss.com

Current

After this change

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@Smankusors Smankusors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ou yeah I just noticed this.... thanks for investigating which commit caused it tho 😅


btw... on the other story, Forms > Chips also have weird underline on the input field, while on the materializecss.com not... 😟

@nekonenene
Copy link
Author

on the other story, Forms > Chips also have weird underline on the input field, while on the materializecss.com not... 😟

Ugh... it seems to come from this change.
https://github.com/Dogfalo/materialize/pull/6313/files

I'm appreciate if you create this issue.

@nekonenene
Copy link
Author

@Smankusors I created the PR now! 🎉 #34

@createdbyken
Copy link
Member

This looks great! Very appreciated <3

@DanielRuf
Copy link

This looks great! Very appreciated <3

Thanks for the feedback. Keep in mind that you can also do a review as member of the members group.

@DanielRuf DanielRuf merged commit 7bf14e0 into materializecss:v1-dev Sep 24, 2020
@Smankusors Smankusors added the bug Something isn't working label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working component: sidenav

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants